feat: use DNS discovery as default bootstrap discovery #1114
Conversation
danisharora099
changed the title
size-limit report 📦
|
I've added 3 tests for the same:
You can find the tests in
Until we release these changes to npm, we can't consume them in our example app unless we build manually. What do you suggest? |
libp2p wasn't by default tagging peers with dns-discovery as
"bootstrap"
-- we are manually now tagging peers with "dns-discovery", and then
running tests according to that
danisharora099
force-pushed
the
feat/dns-disc-default-bootstrap
branch
from
19abac7 to
2fc1246
Compare
|
I've refactored the tests to be more explicit and added usage of |
|
Let me rephrase: we need to dogfood dns discovery before we make it the default discovery strategy. To dogfood it, I suggest to make the |
|
Gotcha. I misinterpreted. Thanks for explaining. I should be able to integrate it with |
| peerInfos.forEach(async (peerInfo) => { | ||
| await this._components.peerStore.tagPeer( | ||
| peerInfo.id, | ||
| DEFAULT_BOOTSTRAP_TAG_NAME, | ||
| { | ||
| value: this._options.tagValue ?? DEFAULT_BOOTSTRAP_TAG_VALUE, | ||
| ttl: this._options.tagTTL ?? DEFAULT_BOOTSTRAP_TAG_TTL, | ||
| } | ||
| ); |
There was a problem hiding this comment.
What are these changes? If more modification to dns discovery is necessary then lets' do that and dog food that first.
There was a problem hiding this comment.
This code just tags these peers in the peer store, and doesn't change any functionality
| relay: maxQuantity, | ||
| store: maxQuantity, | ||
| filter: maxQuantity, | ||
| lightPush: maxQuantity, |
There was a problem hiding this comment.
Do you have to pass this? what about if relay is undefined it means "return all node with relay".
There was a problem hiding this comment.
if undefined is passed for any particular protocol, it initialised it to 0
|
🥳 |
Problem
ref: #517
Solution
moves away from predefined list of nodes, and uses DNS discovery as bootstrap discovery