Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mapping function to multiaddr of peerid #1306

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Apr 17, 2023

Problem

In new version of @libp2p they removed internal mapping from string to Multiaddr

Solution

Create transform function on our side and update types.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 119.37 KB (+2.16% 🔺) 2.4 s (+2.16% 🔺) 942 ms (+0.41% 🔺) 3.4 s
Waku default setup 390.3 KB (+0.6% 🔺) 7.9 s (+0.6% 🔺) 2 s (+8.48% 🔺) 9.8 s
ECIES encryption 28.02 KB (0%) 561 ms (0%) 485 ms (+14.82% 🔺) 1.1 s
Symmetric encryption 28.03 KB (0%) 561 ms (0%) 546 ms (+113.75% 🔺) 1.2 s
DNS discovery 108.07 KB (0%) 2.2 s (0%) 881 ms (-13.5% 🔽) 3.1 s
Privacy preserving protocols 117.87 KB (+1.29% 🔺) 2.4 s (+1.29% 🔺) 754 ms (+8.85% 🔺) 3.2 s
Light protocols 119.68 KB (+1.26% 🔺) 2.4 s (+1.26% 🔺) 874 ms (+3.49% 🔺) 3.3 s
History retrieval protocols 119.66 KB (+1.23% 🔺) 2.4 s (+1.23% 🔺) 546 ms (-3.58% 🔽) 3 s

@weboko weboko force-pushed the weboko/multiaddr branch from 7c56482 to fd3670c Compare April 19, 2023 09:25
@weboko weboko merged commit 763dc01 into master Apr 19, 2023
@weboko weboko deleted the weboko/multiaddr branch April 19, 2023 18:03
danisharora099 pushed a commit that referenced this pull request May 8, 2023
* feat: add mapping function to multiaddr of peerid

* remove unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants