feat!: rename package from @waku/create to @waku/sdk #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
danisharora099
force-pushed
the
feat/waku-sdk
branch
from
5d78482 to
62f2737
Compare
danisharora099
changed the title
fryorcraken
approved these changes
Jun 2, 2023
packages/sdk/CHANGELOG.md
Outdated
There was a problem hiding this comment.
I hope release please will handle the git label change properly...
packages/sdk/package.json
Outdated
| "version": "0.0.14", | ||
| "description": "Easily create a Waku node", | ||
| "name": "@waku/sdk", | ||
| "version": "0.0.15", |
There was a problem hiding this comment.
Hum, so the idea is to manual release after this PR is merged? Sounds good, let's be sure you then tell release please to start from this version.
There was a problem hiding this comment.
This one requires us to remove @waku/create from release-please files and add @waku/sdk to the list of packages being tracked and to manually set next version.
After release of this package happens we need to remove forced version of sdk package`.
fryorcraken
reviewed
Jun 5, 2023
Co-authored-by: fryorcraken.eth <110212804+fryorcraken@users.noreply.github.com>
weboko
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1353
Solution
@waku/createpackage to@waku/sdk@waku/coreand@waku/utilsso that alljs-wakuexamples can be purely done by installing and importing from@waku/sdkNotes / Future TODOs (pending release)
@waku/sdk@waku/sdk@waku/reactto use@waku/sdk