feat: metadata protocol #1732
feat: metadata protocol #1732
Conversation
danisharora099
force-pushed
the
feat/metadata-protocol
branch
from
8b5f328 to
8f04682
Compare
danisharora099
force-pushed
the
feat/metadata-protocol
branch
2 times, most recently
from
c7fee6e to
47b95f1
Compare
danisharora099
force-pushed
the
feat/metadata-protocol
branch
from
47b95f1 to
e691aa7
Compare
size-limit report 📦
|
danisharora099
force-pushed
the
feat/metadata-protocol
branch
2 times, most recently
from
f6976e5 to
4efcad5
Compare
danisharora099
force-pushed
the
feat/metadata-protocol
branch
2 times, most recently
from
fa922b4 to
6524032
Compare
danisharora099
force-pushed
the
feat/metadata-protocol
branch
from
0f9c628 to
61f7e5a
Compare
| }); | ||
| const response = proto_metadata.WakuMetadataResponse.decode(bytes); | ||
| if (!response) { | ||
| throw new Error("Error decoding metadata response"); |
There was a problem hiding this comment.
let's move away from exceptions and use enum error across all req-res interfaces
There was a problem hiding this comment.
yes. updated the issue for metadata & tracked part of #1694
| await tearDownNodes([nwaku1], waku); | ||
| }); | ||
|
|
||
| it("interop", async function () { |
There was a problem hiding this comment.
More tests are needed:
- same cluster, same shard: nodes connect
- same cluster, different shardL nodes connects
- different cluster, same shard, node disconnect
- different cluster, different shard, node disconnects
There was a problem hiding this comment.
right, thanks!
ca17b30
| this.shardInfo | ||
| ); | ||
|
|
||
| await pipe([encodedResponse], lp.encode, streamData.stream); |
There was a problem hiding this comment.
The metadata request contains the shardinfo from the remote node. We should save it locally.
| await waku.libp2p.dialProtocol(nwaku1Ma, MetadataCodec); | ||
|
|
||
| await expect( | ||
| waku.libp2p.services.metadata?.query(nwaku1PeerId) |
There was a problem hiding this comment.
What is that?
It seems better to check whether you have an active connection with the node, as the expectation is no active connection.
There was a problem hiding this comment.
the metadata query fails (with a throw) if the clusters are different between the service node it's attempting to dial therefore the expecting a catch
you're right in pointing out that there will no active connection, you're right in pointing out that the connection will be closed so good to add an expect for that as well: d53eddb
--
wanted to be explicit with making the query, but perhaps it's simpler to remove the query() attempt and directly expect the connection to be dropped:d53eddb
This PR introduces the Metadata Protocol as a service
Notes: