-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter.createSubscription accept ShardParams #1967
Comments
Looks right to me. Good point. Thanks for flagging this @vpavlin Looks like the filter API wasn't updated after we introduced autosharding. Moving to priority. @adklempner are you happy to address this? |
I agree with @vpavlin and I think better way would be to simplify as much as possible but also allow to make fine tuning. For that I see we can do:
Since I am touching this code in #1958 I might be able to address it there. |
@weboko issue seems to be in the "done" column but still open -- I guess we can close it? |
support request
Problem
It seems like
filter.createSubscription
accepts eitherpubsubTopic
orSingleShardInfo
- which in turn consists ofClusterId
andshard
Would it make more sense to accept
ShardingParams
to make it more flexible?Requiring
SingleShardInfo
forces me to get the shard from contentTopic before callingcreateSubscription
, which seems unnecessary to be done by a user/dev.But I might be missing the reasoning behind this choice:)
Proposed Solutions
Notes
The text was updated successfully, but these errors were encountered: