Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js to js waku relay publish does not seem reproducable in test #7

Closed
D4nte opened this issue Mar 23, 2021 · 2 comments · Fixed by #22
Closed

js to js waku relay publish does not seem reproducable in test #7

D4nte opened this issue Mar 23, 2021 · 2 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@D4nte
Copy link
Contributor

D4nte commented Mar 23, 2021

Problem

Not able to confirm that publication of messages using waku relay works between two nodes using js-waku despite it being working between nim-waky and js-waku nodes.

Solution

Further investigate the issue

Acceptance criteria

This test passes https://github.com/status-im/js-waku/blob/46869e998d710d410450fff66e0ba83ca99b1d4c/src/lib/waku_relay.spec.ts#L75

@D4nte D4nte mentioned this issue Mar 28, 2021
4 tasks
@D4nte D4nte added this to the waku-relay (node) milestone Mar 28, 2021
@D4nte D4nte added bug Something isn't working waku relay labels Apr 1, 2021
@oskarth
Copy link

oskarth commented Apr 1, 2021

Any idea what could be causing this? Does stock JS gossipsub example work JS-JS?

@D4nte
Copy link
Contributor Author

D4nte commented Apr 1, 2021

Any idea what could be causing this? Does stock JS gossipsub example work JS-JS?

I have found the issue now, this is what I mentioned today in the chat. Currently writing code to fix it.

gossipsub check against the gossipsub protocol in various places (when joining, when publishing, at heartbeat, etc).

I did override to use waku protocol in some places, but not all. So in some cases it was working, but in the case of js<>js tests, both node subscribe at the same to the topic so it goes through a different flow than all nim<>js tests. In this flow, the fact that I did not replace the gossipsub protocol with waku relay in _publish created the issue.

@D4nte D4nte mentioned this issue Apr 1, 2021
@bors bors bot closed this as completed in 3be5763 Apr 1, 2021
@bors bors bot closed this as completed in #22 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants