Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln-relay): Manage reconnections to the eth node #1306

Closed
2 tasks done
rymnc opened this issue Oct 27, 2022 · 1 comment
Closed
2 tasks done

feat(rln-relay): Manage reconnections to the eth node #1306

rymnc opened this issue Oct 27, 2022 · 1 comment
Assignees
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@rymnc
Copy link
Contributor

rymnc commented Oct 27, 2022

Problem

When a wakunode running waku-rln-relay gets disconnected from the eth node, there is no attempt to reconnect to it, and therefore, will count every new message as invalid since it cannot receive updates to the membership group, and thereby cannot update its local merkle tree.

Suggested solution

After #1266 has been addressed, reconnection to the eth node must be handled, and events should be fetched from the last processed block.

Alternatives considered

Additional context

Acceptance criteria

  • Reconnection to the eth node
  • Resubscription to membership altering events with the last processed block
@rymnc rymnc added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Oct 27, 2022
@rymnc
Copy link
Contributor Author

rymnc commented Jan 16, 2023

Addressed in #1465. Will close upon its merge

@rymnc rymnc self-assigned this Jan 16, 2023
@rymnc rymnc added this to the Release 0.15.0 milestone Jan 16, 2023
@rymnc rymnc moved this to Review/QA in Vac Research Jan 16, 2023
@rymnc rymnc moved this from Review/QA to Done in Vac Research Jan 16, 2023
@rymnc rymnc closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Development

No branches or pull requests

1 participant