Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unused import warning in tests #1398

Open
alrevuelta opened this issue Nov 17, 2022 · 2 comments
Open

chore: unused import warning in tests #1398

alrevuelta opened this issue Nov 17, 2022 · 2 comments

Comments

@alrevuelta
Copy link
Contributor

Background

Some tests like ./tests/v2/test_waku_filter.nim can't be run isolated without importing chronicles. If that import is removed, then the following fails. Note that this was fixed in #1375.

$ ./env.sh bash
$ nim c -r ./tests/v2/test_waku_filter.nim

However, after this fix, we get an UnusedImport warning when compiling all tests. This is clearly not the case, since as stated, if this import is removed the test can't be run isolated.

Acceptance criteria

UnusedImport is not shown anymore when compiling the tests make test2 but we still can run tests isolated.

@alrevuelta
Copy link
Contributor Author

Check:

when defined(nimHasUsed): {.used.}

@jm-clius jm-clius moved this to Icebox in Waku Nov 21, 2022
@vpavlin
Copy link
Member

vpavlin commented Jul 15, 2023

Is this still the case? I am not sure from the referenced PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

3 participants