-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rln-relay): update message validation #1451
Comments
@s1fr0 I'm not sure if Poseidon was implemented for nim. I did find this in nwaku/waku/v2/protocol/waku_rln_relay/rln.nim Lines 143 to 150 in 2b1741e
but it's keccak. Maybe worthwhile to expose the poseidon hasher via ffi as well? |
@s1fr0 should we move this issue to the next release given that there are pending circuit improvements which will change the scope? |
@rymnc Agreed, although I believe exposing Poseidon is a good idea regardless. |
Reference issue in zerokit: vacp2p/zerokit#110 |
Background
Based on -
rln_identifier
vacp2p/research#152Details
Messages will be sent with
rln_identifier
,epoch
, andexternal_nullifier
as usual, however theepoch
is no longer used as theexternal_nullifier
. We need to hash theepoch
andrln_identifier
(poseidon([epoch, rln_identifier])
) to get theexternal_nullifier
, which we compare with theexternal_nullifier
sent along with the message.Acceptance criteria
external_nullifier
in Waku RLN RelayThe text was updated successfully, but these errors were encountered: