-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(networking): get relay number of connections from protocol conns/streams #1609
Conversation
cc @Menduist |
2fee3fc
to
d33a7a7
Compare
29459f2
to
24f28a8
Compare
0352e21
to
24e40ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature and will be great to have this accurately reported. Change request relates to knowledge of codecs within peer manager, which I think we can avoid if I'm not missing something.
8c574c3
to
c3d7a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last request before merging is to move the new utils
to /waku/common
. We're trying to slowly deprecate the somewhat hotchpotch mix of utils
: if a utility is closely related to a specific module e.g. peers
, it should be moved closer to the peer modules in future, if it is truly general or common
, as I think both of yours are, it should go to /waku/common
. Apologies for missing in the first review. Otherwise lgtm.
This PR leverages the changes introduced by #1622.
Closes #1566
Summary:
waku_streams_peers
metric and fixeswaku_connected_peers
, that should offer more granularity to node operators, providing more info on which protocols are being used by the existing connections.