Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nwaku static sharding #1643

Closed
6 tasks done
LNSD opened this issue Apr 4, 2023 · 2 comments
Closed
6 tasks done

feat: nwaku static sharding #1643

LNSD opened this issue Apr 4, 2023 · 2 comments
Assignees
@jm-clius
Labels
E:Static sharding See https://github.com/waku-org/pm/issues/15 for details
Milestone
Release 0.19.0

Comments

@LNSD
Copy link
Contributor

LNSD commented Apr 4, 2023 •
edited by jm-clius
Loading

Problem

See waku-org/pm#15

Suggested solution

TBD

Additional context

  • Waku ENR fields.
    • multiaddr field is not encoded using "machine friendly" encoding (see this), we are just converting from utf-8 to bytes and back. The space occupied by the multiaddr could be optimized by using the machine format of the multiaddress spec.

Acceptance criteria

  • Rework the pub-sub topic namespacing types and validation.
  • Extensible ENR types (builder + TypedRecord accessors)
  • Adapt the ENR capabilities (waku2) and multiaddr entries.
  • Support topic validation of the command-line arguments.
  • Add ENR support for the topic sharding field.
  • TBD: Add logic to discovery mechanisms to act upon discovering a node that supports certain topic shards.
@LNSD LNSD self-assigned this Apr 4, 2023
@oskarth oskarth added this to Vac Research and Waku Apr 4, 2023
@LNSD LNSD mentioned this issue Apr 4, 2023
Closed
6 tasks
@LNSD LNSD moved this to In Progress in Waku Apr 4, 2023
@LNSD LNSD added this to the Release 0.17.0 milestone Apr 4, 2023
@vpavlin
Copy link
Member

vpavlin commented May 16, 2023

Seems like there is still work to be done, so moving to next release

@jm-clius jm-clius moved this from In Progress to Priority in Waku May 16, 2023
@jm-clius jm-clius moved this from Priority to In Progress in Waku May 30, 2023
@jm-clius jm-clius assigned jm-clius and unassigned LNSD May 30, 2023
@jm-clius jm-clius mentioned this issue Jun 1, 2023
Closed
3 tasks
@vpavlin vpavlin modified the milestones: Release 0.18.0, Release 0.19.0 Jun 9, 2023
@jm-clius
Copy link
Contributor

Closed and tracked in #1776

@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Jun 20, 2023
@fryorcraken fryorcraken added the E:Static sharding See https://github.com/waku-org/pm/issues/15 for details label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jm-clius jm-clius

Labels
E:Static sharding See https://github.com/waku-org/pm/issues/15 for details
Projects
Waku
Archived in project
Milestone
Release 0.19.0
Development

No branches or pull requests
4 participants
@LNSD @vpavlin @jm-clius @fryorcraken