Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unstable peers in mesh #1710

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: unstable peers in mesh #1710

merged 1 commit into from
May 2, 2023

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented May 2, 2023 •
edited
Loading

Closes #1669

Summary:

  • Due to a bug in nim-libp2p, amount of peers in mesh were unstable, fluctuating a lot and even dropping below D_low.
  • This was fixed upstream in Fix gossipsub dOut handling vacp2p/nim-libp2p#883 and this PR bumps to the latest version containing the fix.
  • Tested in the sandbox machine see

@alrevuelta alrevuelta requested review from rymnc and jm-clius May 2, 2023 11:05
rymnc
rymnc approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch

jm-clius
jm-clius approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@alrevuelta alrevuelta merged commit 703c3ab into master May 2, 2023
@alrevuelta alrevuelta deleted the bump-libp2p-bug branch May 2, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: amount of peers in the mesh fluctuates a lot even in controlled environments
3 participants
@alrevuelta @rymnc @jm-clius