Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): use new config for ffi #1718

Merged
merged 3 commits into from
May 10, 2023
Merged

chore(rln-relay): use new config for ffi #1718

merged 3 commits into from
May 10, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 5, 2023 •
edited
Loading

Description

Since we pass in a json string to the ffi for additional configs, this pr updates nwaku to do the same

Changes

@rymnc rymnc self-assigned this May 5, 2023
@rymnc rymnc marked this pull request as ready for review May 10, 2023 07:19
@rymnc rymnc requested a review from alrevuelta May 10, 2023 07:19
alrevuelta
alrevuelta approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@rymnc
Copy link
Contributor Author

rymnc commented May 10, 2023

sorry about the ci failures, it was expected since tree initialization changed upstream :)

@rymnc rymnc merged commit 44c5431 into master May 10, 2023
@rymnc rymnc deleted the update-rln-ffi-args branch May 10, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rymnc @alrevuelta