Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): allow passing in an index to the keystore #1774

Closed
1 task done
rymnc opened this issue Jun 1, 2023 · 0 comments · Fixed by #1777
Closed
1 task done

chore(rln-relay): allow passing in an index to the keystore #1774

rymnc opened this issue Jun 1, 2023 · 0 comments · Fixed by #1777

Comments

@rymnc
Copy link
Contributor

rymnc commented Jun 1, 2023 •
edited
Loading

Background

Currently, all credentials are loaded into the keystore path provided, but by default, nwaku chooses the 0th credential in the array -

nwaku/waku/v2/waku_rln_relay/group_manager/on_chain/group_manager.nim

Line 443 in 6257874

# TODO: accept an index from the config (related: https://github.com/waku-org/nwaku/pull/1466)

Details

  • Use the existing --rln-relay-membership-index flag to choose the appropriate credential

Acceptance criteria

  • Operators can decide which rln credentials they wish to use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rln-relay): pass in index to keystore credentials waku-org/nwaku
1 participant
@rymnc