chore(rln-relay): pass in the path to the tree db #1782
Conversation
apps/wakunode2/config.nim
Outdated
| @@ -201,6 +201,11 @@ type | |||
| defaultValue: "" | |||
| name: "rln-relay-cred-password" }: string | |||
|
|
|||
| rlnRelayTreePath* {. | |||
| desc: "Path to the RLN merkle tree db", | |||
There was a problem hiding this comment.
What type of db is expected? Maybe it is worth specifying it a bit more :)
There was a problem hiding this comment.
Yes! good idea, addressed in 69dc716
| mode: "high_throughput", | ||
| compression: false, | ||
| flush_interval: 12_000, | ||
| path: if tree_path != "": tree_path else: DefaultRlnTreePath |
There was a problem hiding this comment.
I think we can directly pass the tree_path variable as it already has an appropriate default value.
| path: if tree_path != "": tree_path else: DefaultRlnTreePath | |
| path: tree_path |
There was a problem hiding this comment.
Would have to disagree there, since the default value from the wakunode config is "", and could potentially be passed into this proc
| ## wrapper around the generic JObject constructor. | ||
| ## We don't need to have a separate proc for the tree_config field | ||
| let tree_config = %{ "cache_capacity": %c.tree_config.cache_capacity, | ||
| "mode": %c.tree_config.mode, |
There was a problem hiding this comment.
Maybe very basic question but what does % do by default in Nim? :)
There was a problem hiding this comment.
If std/json is imported, % converts the type of the variable to a JsonNode
There was a problem hiding this comment.
ah true, I forgot it. Thanks! We do the same in
Co-authored-by: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com>
| @@ -53,14 +53,14 @@ proc membershipKeyGen*(ctxPtr: ptr RLN): RlnRelayResult[IdentityCredential] = | |||
|
|
|||
| return ok(identityCredential) | |||
|
|
|||
| type RlnTreeConfig* = ref object of RootObj | |||
| type RlnTreeConfig = ref object of RootObj | |||
| cache_capacity*: int | |||
Description
This pr allows the user/operator to pass in the path to the persisted merkle tree, this will allow users to only sync
from the block that they need to, instead of syncing from the start every single time.
Changes
createRlnInstanceLocal, which is the only proc thatuses it
--rln-relay-tree-paththat accepts a stringNote:
the prs to reduce cognitive load.
Issue
addresses a part of #1772