Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): flaky static group manager test #1798

Merged
merged 1 commit into from
Jun 14, 2023
Merged

fix(rln-relay): flaky static group manager test #1798

merged 1 commit into from
Jun 14, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jun 13, 2023 •
edited
Loading

Description

Generates a new temp path for the tree db, as it was failing intermittently due to same path being used between tests.

Changes

  • imports std/tempfiles and generates a new temp path

Issue

closes #1796

@rymnc rymnc changed the title fix(rln-relay): flaky static group manager test) fix(rln-relay): flaky static group manager test Jun 14, 2023
@rymnc rymnc requested a review from Ivansete-status June 14, 2023 10:34
@rymnc rymnc self-assigned this Jun 14, 2023
Ivansete-status
Ivansete-status approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !
What does createTempPath do under the hood?

@rymnc
Copy link
Contributor Author

rymnc commented Jun 14, 2023

https://nim-lang.org/docs/tempfiles.html#genTempPath%2Cstring%2Cstring%2Cstring

@rymnc rymnc marked this pull request as ready for review June 14, 2023 15:25
@rymnc rymnc merged commit 0e9ecbd into master Jun 14, 2023
@rymnc rymnc deleted the test-rln-flaky-static branch June 14, 2023 15:25
SionoiS pushed a commit that referenced this pull request Jun 19, 2023
@rymnc @SionoiS
fix(rln-relay): flaky static group manager test (#1798)
c5a4a8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: test_rln_group_manager_static.nim fails randomly
2 participants
@rymnc @Ivansete-status