Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set limit on store responses #1809

Closed
Tracked by #2032
alrevuelta opened this issue Jun 19, 2023 · 3 comments
Closed
Tracked by #2032

feat: set limit on store responses #1809

alrevuelta opened this issue Jun 19, 2023 · 3 comments

Comments

@alrevuelta
Copy link
Contributor

Problem

Store nodes have no limits on the amount of requests they process (in terms of req/s or served bytes/s per peer)

Suggested solution

Set limits on how many requests/second and/or bytes/second a store node can serve to each peer

@jm-clius
Copy link
Contributor

Idea from offsite: use token bucket in chronos to rate limit. Should be simple to do and provide basic request rate limiting. May need more sophisticated solution to also limit e.g. response size allocation per client.

@chair28980
Copy link
Contributor

chair28980 commented Jan 2, 2024

Might be duplicated in node bandwidth management issue #2032

@NagyZoltanPeter
Copy link
Contributor

@chair28980 : It can be closed as solved by: #2390

@github-project-automation github-project-automation bot moved this from Icebox to Done in Waku Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants