Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(networking): disconnect due to colocation ip in conn handler #1821

Merged
merged 1 commit into from
Jun 28, 2023
Merged

chore(networking): disconnect due to colocation ip in conn handler #1821

merged 1 commit into from
Jun 28, 2023

Conversation

alrevuelta
Copy link
Contributor

Description

  • Before: Disconnections due to ip collocation factor where triggered at a given fixed interval, using a "cleanup" function scheduled every few seconds.
  • With this PR: Disconnections are triggered in the connection handle, which is executed right after the peer joins. This allows to react faster to such attacks, where we are attacked by sybils under the same IP.
  • It also uses asyncSpawn to trigger disconnections instead.

@alrevuelta alrevuelta merged commit e12c979 into master Jun 28, 2023
@alrevuelta alrevuelta deleted the prune-by-ip-handle branch June 28, 2023 07:14
@alrevuelta alrevuelta mentioned this pull request Jun 30, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

@SionoiS SionoiS Awaiting requested review from SionoiS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alrevuelta @jm-clius