-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update ENR based on RPC topic subscribe #1843
Comments
A bit of a conundrum here. Discv5 is no longer in It seams like ALL protocols must be in Architecturally, sending information from rpc handlers to whichever protocol needs it in an abstract way (channels?) would be best. The alternative would be to pass |
good catch. random idea. perhaps some kind of action can be triggered after subs/unsubs to new topics. like this we can avoid this depencancy. some hook? |
I talked with @fryorcraken and I guess there's 3 options
The decision will affect peer management. This seams to be less related to autosharding so I changed the epic. |
|
For topic subscriptions we are now using an event system. |
Problem
Subscribing to a new topics via RPC does not update the ENR when using shards.
Suggested solution
discv5 has a way to update the record. Create the same in waku discv5.
Alternatives considered
Restarting the node with new topics always works but is annoying.
Additional context
https://github.com/status-im/nim-eth/blob/285da12bf318a2e21182dc2453a4a30c58f73067/eth/p2p/discoveryv5/protocol.nim#L247
Acceptance criteria
/waku/2/rs/16/0
via RPC should update the ENR in waku discv5.The text was updated successfully, but these errors were encountered: