-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Waku v1 and wakubridge code #1874
Conversation
Marking as ready for review, as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Do we keep track of who use what API somewhere? Would be useful to not forget ppl when communicating big changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jm-clius thanks for this!!
Indeed. You'll see I mentioned that as excluded from scope in the description simply to keep this PR a bit more contained :) |
Description
This PR addresses the bulk of the changes necessary for #1767.
It removes the legacy Waku ("Waku v1") and Waku v1 <> v2 bridge ("Waku Bridge") code from the nwaku repo.
This touches a great many files, so I'll try to give reviewers some context about possible impact(s) under
Changes
.The Waku v1 code is now maintained in https://github.com/waku-org/waku-legacy.
The Waku bridge code is now maintained in https://github.com/waku-org/waku-bridge.
Note that the
waku-bridge
repo requires some of the changes in this PR to be fully functional with working CI, although all necessary code has been moved.waku-legacy
repo is complete, with functioning CI if any changes are to be made in future.Scope of changes
wakunode1
from the release artifacts. From now one we won't includewakunode1
in releases.wakunode1
andwakubridge
build tasks from the Makefile. This will affect Jenkins deployment jobs, such as https://ci.infra.status.im/job/nim-waku/job/deploy-bridge-test/, https://ci.infra.status.im/job/nim-waku/job/deploy-bridge-prod/ and https://ci.infra.status.im/job/nim-waku/job/deploy-wakuv1-test/nwaku
, which I'd like to avoid if possibleWhat is excluded from scope?
Removing references to
v2
, e.g. changing import paths fromwaku/v2
to justwaku/
. This would clutter this PR even more, so will be done in a subsequent step.What should be reviewed?
The impact of items marked as "NB" under
Scope of Changes
and any other high-impact consequences of removing v1 code that I might have missed.