Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Waku v1 and wakubridge code #1874

Merged
merged 10 commits into from
Aug 7, 2023
Merged

chore: remove Waku v1 and wakubridge code #1874

merged 10 commits into from
Aug 7, 2023

Conversation

jm-clius
Copy link
Contributor

@jm-clius jm-clius commented Aug 2, 2023

Description

This PR addresses the bulk of the changes necessary for #1767.

It removes the legacy Waku ("Waku v1") and Waku v1 <> v2 bridge ("Waku Bridge") code from the nwaku repo.
This touches a great many files, so I'll try to give reviewers some context about possible impact(s) under Changes.

The Waku v1 code is now maintained in https://github.com/waku-org/waku-legacy.
The Waku bridge code is now maintained in https://github.com/waku-org/waku-bridge.
Note that the waku-bridge repo requires some of the changes in this PR to be fully functional with working CI, although all necessary code has been moved. waku-legacy repo is complete, with functioning CI if any changes are to be made in future.

Scope of changes

What is excluded from scope?

Removing references to v2, e.g. changing import paths from waku/v2 to just waku/. This would clutter this PR even more, so will be done in a subsequent step.

What should be reviewed?

The impact of items marked as "NB" under Scope of Changes and any other high-impact consequences of removing v1 code that I might have missed.

@jm-clius jm-clius changed the title Chore/remove v1 chore: remove Waku v1 and wakubridge code Aug 2, 2023
@jm-clius jm-clius marked this pull request as ready for review August 4, 2023 09:59
@jm-clius
Copy link
Contributor Author

jm-clius commented Aug 4, 2023

Marking as ready for review, as:

  • confirmed that Jenkins deployment is disabled for Waku v1 and not used for wakubridge
  • confirmed from stakeholders that deprecated Private API is not roadmapped

Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
🥇

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do we keep track of who use what API somewhere? Would be useful to not forget ppl when communicating big changes.

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!
In the future, I think we should delete any reference to "v2" or "2" (e.g. wakunode2)

Also, I'd remove the 'v1' and 'v2' folders and put all the content underneath 'v2' right under the 'waku' folder, and just mention that in the CHANGELOG.md.
image

@alrevuelta alrevuelta self-requested a review August 7, 2023 12:08
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jm-clius thanks for this!!

@jm-clius
Copy link
Contributor Author

jm-clius commented Aug 7, 2023

In the future, I think we should delete any reference to "v2" or "2" (e.g. wakunode2)

Indeed. You'll see I mentioned that as excluded from scope in the description simply to keep this PR a bit more contained :)

@jm-clius jm-clius merged commit ab344a9 into master Aug 7, 2023
@jm-clius jm-clius deleted the chore/remove-v1 branch August 7, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants