You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we build our container (Docker) images we rebuild wakunode from scratch. This is generally ok as the whole build process is mostly self-contained, but there is still a tiny chance of the resulting binary in the container to differ from the released binaries and it wastes resources/time.
It would make more sense to build the container images from existing binaries - especially for releases (vX.Y.Z), but also for commits in master and we can even use this to build images per PR
Details
Come up with an alternative Dockerfile (Dockerfile.binaries ?) which would pick up a wakunode2 binary from predefined location rather than rebuild it
Use this new Dockefile in Github Actions workflows - CI (for PRs and master merges), pre-release, release...
Setup pushes to some registry (for PRs, it would be ideal to separate from the main statusteam/nim-waku docker repo, and ideall use quay.io as that allows to automatically clean up the images after X days)
Acceptance criteria
New Dockerfile working with pre-built binaries exists
The build of this image is integrated into ci.yml (ideally comment is posted on the issue with a link to the newly built image)
The build of this image is integrated into pre-release.yml
The build of this image is integrated into release-assets.yml
Images are generally available in some docker registry/repository and documentation is updated to where to find these images
The text was updated successfully, but these errors were encountered:
Background
When we build our container (Docker) images we rebuild wakunode from scratch. This is generally ok as the whole build process is mostly self-contained, but there is still a tiny chance of the resulting binary in the container to differ from the released binaries and it wastes resources/time.
It would make more sense to build the container images from existing binaries - especially for releases (vX.Y.Z), but also for commits in
master
and we can even use this to build images per PRDetails
Dockerfile.binaries
?) which would pick up awakunode2
binary from predefined location rather than rebuild itstatusteam/nim-waku
docker repo, and ideall use quay.io as that allows to automatically clean up the images after X days)Acceptance criteria
The text was updated successfully, but these errors were encountered: