Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build a container image from existing binaries #1877

Open
5 tasks
Tracked by #1889
vpavlin opened this issue Aug 3, 2023 · 1 comment
Open
5 tasks
Tracked by #1889

chore: build a container image from existing binaries #1877

vpavlin opened this issue Aug 3, 2023 · 1 comment
Labels
effort/weeks Estimated to be completed in a few weeks

Comments

@vpavlin
Copy link
Member

vpavlin commented Aug 3, 2023

Background

When we build our container (Docker) images we rebuild wakunode from scratch. This is generally ok as the whole build process is mostly self-contained, but there is still a tiny chance of the resulting binary in the container to differ from the released binaries and it wastes resources/time.

It would make more sense to build the container images from existing binaries - especially for releases (vX.Y.Z), but also for commits in master and we can even use this to build images per PR

Details

  • Come up with an alternative Dockerfile (Dockerfile.binaries ?) which would pick up a wakunode2 binary from predefined location rather than rebuild it
  • Use this new Dockefile in Github Actions workflows - CI (for PRs and master merges), pre-release, release...
  • Setup pushes to some registry (for PRs, it would be ideal to separate from the main statusteam/nim-waku docker repo, and ideall use quay.io as that allows to automatically clean up the images after X days)

Acceptance criteria

  • New Dockerfile working with pre-built binaries exists
  • The build of this image is integrated into ci.yml (ideally comment is posted on the issue with a link to the newly built image)
  • The build of this image is integrated into pre-release.yml
  • The build of this image is integrated into release-assets.yml
  • Images are generally available in some docker registry/repository and documentation is updated to where to find these images
@vpavlin vpavlin moved this to To Do in Waku Aug 22, 2023
@Ivansete-status Ivansete-status added the effort/weeks Estimated to be completed in a few weeks label May 8, 2024
@Ivansete-status
Copy link
Collaborator

Thanks for that one @vpavlin !
I think the following is already implemented as we enjoy the PR quay.io images ;)

and ideall use quay.io as that allows to automatically clean up the images after X days


Besides, is interesting to start using some registry for permanent binaries. I was thinking of Artifactory . Or do you know another fancy option ;P?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/weeks Estimated to be completed in a few weeks
Projects
Status: To Do
Development

No branches or pull requests

2 participants