Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): only add comment on PR and do not duplicate it #1908

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Aug 11, 2023

Description

This PR makes sure the comment step only runs on PRs (as it fails CI for master otherwise)

It also configures the action to only update the comment and not post a new comment after each CI run

Changes

  • add condition to only run on PRs
  • update the comment rather than add new comment on each run

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1908

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorgeous! Thanks for it!

@vpavlin vpavlin merged commit b785b6b into master Aug 11, 2023
@vpavlin vpavlin deleted the fix/comment-master-update branch August 11, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants