Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): timeout on macos runners, use fixed version of ganache #1913

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Aug 16, 2023

Description

The macos runners were timing out consistently due to a version change in ganache. This pr addresses it by locking the
version of ganache used, and killing the child processes that ganache creates

Changes

  • kills all ganache's
  • version lock

@rymnc rymnc self-assigned this Aug 16, 2023
@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:1913

@rymnc rymnc marked this pull request as ready for review August 16, 2023 11:13
Copy link
Member

@vpavlin vpavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man 🤦

@rymnc rymnc merged commit c9772af into master Aug 16, 2023
12 checks passed
@rymnc rymnc deleted the fix-timeout-issue branch August 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants