feat(discv5): update filter predicate #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at |
This was referenced Aug 18, 2023
jm-clius
approved these changes
Aug 22, 2023
| @@ -314,8 +320,12 @@ proc subscriptionsListener*(wd: WakuDiscoveryV5, topicSubscriptionQueue: AsyncEv | |||
| if unsubRes.isErr(): | |||
| debug "ENR shard removal failed", reason= $unsubRes.error | |||
|
|
|||
| if subRes.isOk() and unsubRes.isOk(): | |||
| debug "ENR updated successfully" | |||
| if subRes.isErr() and unsubRes.isErr(): | |||
There was a problem hiding this comment.
Should this better be an or ?
There was a problem hiding this comment.
if either one succeed then add the log message and update the predicate.
There was a problem hiding this comment.
Failing is not that bad in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the way the discovery predicate is computed. Instead of passing a record to
searchLoopit uses the record already in discv5 if possible. Also, when the ENR is updated the predicate is too.Changes
Follow up from #1875