Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peer management with shard as a dimension #1940

Closed
chair28980 opened this issue Aug 24, 2023 · 4 comments
Closed

feat: Peer management with shard as a dimension #1940

chair28980 opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@chair28980
Copy link
Contributor

If we assume that peer discovery takes care of filtering peers by shard, these peers must now be managed in a way that makes sense in a dynamic auto-sharded environment. Some requirements/ideas:

  • peer store must preferably try to keep at least a target n peers for each subscribed shard (note that dynamically subscribing/unsubscribing from shards could complicate this)
  • peer manager must attempt to maintain a healthy relay connectivity for each subscribed shard
  • a mechanism to perform ad-hoc discovery (or another solution) to cater for when a node subscribes to a shard for which there are no tracked peers

Priority: Critical for launch

@chair28980 chair28980 moved this to To Do in Waku Aug 29, 2023
@chair28980 chair28980 moved this from To Do to Priority in Waku Sep 12, 2023
@fryorcraken fryorcraken added E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details and removed E:2023-1mil-users labels Sep 12, 2023
@chair28980 chair28980 moved this from Priority to In Progress in Waku Sep 26, 2023
@SionoiS
Copy link
Contributor

SionoiS commented Oct 27, 2023

Weekly Update

  • achieved: Waku Metadata shard subscriptions, Sharded relay peer management, draft sharded peer store pruning
  • next: finalize sharded peer store pruning & run simulations

@SionoiS
Copy link
Contributor

SionoiS commented Nov 10, 2023

Weekly Update

  • achieved: discv5 filter peer by capability, misc. improvement w.r.t sharding and tests, sharded peer management improvement
  • next: run more simulations

@SionoiS
Copy link
Contributor

SionoiS commented Dec 1, 2023

Weekly Update

  • achieved: sharded peer management final version in review
  • next: review feedback

@SionoiS
Copy link
Contributor

SionoiS commented Dec 7, 2023

Weekly Update

  • achieved: sharded peer management and store pruning PR merged

@SionoiS SionoiS closed this as completed Dec 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Archived in project
Development

No branches or pull requests

4 participants