chore(ci): add js-waku test to pre-release workflow #2017
Conversation
|
You can find the image built from this PR at Built from 1682989 |
|
You can find the experimental image built from this PR at Built from 0246cfb |
vpavlin
force-pushed
the
chore/add-js-waku-pre-release
branch
from
2b53b6a to
45cd317
Compare
vpavlin
force-pushed
the
chore/add-js-waku-pre-release
branch
from
45cd317 to
6bf5a37
Compare
| - name: Vars | ||
| id: vars | ||
| run: | | ||
| TAG=$([[ "${{github.ref}}" == "refs/heads/master" ]] && echo "${{env.RELEASE_NAME}}" || echo ${{github.ref}} | sed 's#refs/tags/##') |
There was a problem hiding this comment.
We don't tend to have many frequent PRs being merged. However, I suggest creating a separate release branch, e.g. release/0.20, each time we create a release so that we make sure that nothing else gets added inadvertently during the release process. (A possible improvement for the future.)
There was a problem hiding this comment.
Yeah, we do that already - the check for master here is because the same PR is used for nightly, so if the build comes from master, rather than v*-rc.*, we want to call it nightly
| js-waku: | ||
| needs: build-docker-image | ||
| uses: waku-org/js-waku/.github/workflows/ci.yml@master | ||
| with: | ||
| nim_wakunode_image: ${{ needs.build-docker-image.outputs.image }} | ||
| caller: nwaku |
There was a problem hiding this comment.
For me to understand: what does that do?
Thanks in advance!
Edited: I think it runs the integration tests from js-waku.
There was a problem hiding this comment.
Yes, uses at job level specifies the workflow YAML file to use for the job to execute (can be local to the repo or external -as seen here), then with specifes input parameters for the called workflow - the PR/pre-release image and then also specify the call comes from nwaku so that we can limit the jobs in js-waku CI that get executed (e.g. we do not want to do release:) )
Description
This PR builds on top of #2006 and adds image build and js-waku execution to pre-release workflow - i.e.
nightlyand release candidatesExample execution in test org - https://github.com/nwaku-test-org/nwaku/actions/runs/6123037927
Changes
inputto docker build job to be able to pass explicit tag