Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HTTP REST API: lightpush #2040

Closed
Tracked by #1076
NagyZoltanPeter opened this issue Sep 15, 2023 · 2 comments · Fixed by #2052
Closed
Tracked by #1076

feat: HTTP REST API: lightpush #2040

NagyZoltanPeter opened this issue Sep 15, 2023 · 2 comments · Fixed by #2052
Assignees
@NagyZoltanPeter
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details

Comments

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented Sep 15, 2023 •
edited
Loading

Problem

This forms a subtask of #1076.

Implement wakunode REST API endpoint that supports LightPush protocol.
19/WAKU2-LIGHTPUSH definition is to be supported and accessible via HTTP REST interface.

Suggested solution

Follow existing REST interface implementartions.

Acceptance criteria

[X] working HTTP LightPush Client REST API to perform filter client operations on remote service nodes
[X] sufficient unit tests for basic functionality
[X] integration of LightPush Client API into the wakunode2 app
@NagyZoltanPeter NagyZoltanPeter self-assigned this Sep 15, 2023
@NagyZoltanPeter NagyZoltanPeter moved this to To Do in Waku Sep 15, 2023
@NagyZoltanPeter NagyZoltanPeter moved this from To Do to In Progress in Waku Sep 15, 2023
@NagyZoltanPeter
Copy link
Contributor Author

Weekly Update

  • achieved:
  • next: LightPush REST endpoint will be implemented fully and put on PR review
  • blocking:

This was referenced Sep 14, 2023
Closed
Merged
@NagyZoltanPeter NagyZoltanPeter linked a pull request Sep 19, 2023 that will close this issue
feat: lightpush rest api #2052
Merged
@NagyZoltanPeter NagyZoltanPeter moved this from In Progress to Code Review / QA in Waku Sep 19, 2023
@NagyZoltanPeter NagyZoltanPeter added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Sep 20, 2023
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Sep 22, 2023
@NagyZoltanPeter
Copy link
Contributor Author

Weekly Update

  • achieved: Lightpush REST API endpoint merged to master
  • next: Admin REST endpoint, extended health endpoint, Full swagger doc of nwaku rest API interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lightpush rest api waku-org/nwaku
1 participant
@NagyZoltanPeter