Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: light push response is empty when meta field is too large #2059

Closed
fryorcraken opened this issue Sep 21, 2023 · 2 comments
Closed

bug: light push response is empty when meta field is too large #2059

fryorcraken opened this issue Sep 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@fryorcraken
Copy link
Collaborator

Problem

When js-waku client tries to use light push with a waku message that has large meta, nwaku sends an empty response back.

Expected: an error in the light push response to point towards the payload size issue.

Impact

To reproduce

If you can reproduce the behavior, steps to reproduce:

  1. Start nwaku with light push
  2. Send a light push rpc request that contains a large meta
  3. get an empty rpc light push response

Expected behavior

rpc light push response contains:

is_success = false
info = "<error message about meta or field>"

Screenshots/logs

wakunode_Waku_Light_Push_[node_only]_Fails_to_push_message_with_large_meta.log

ERR 2023-09-21 02:20:22.908+00:00 failed to decode rpc                       topics="waku lightpush" tid=1 file=protocol.nim:43

nwaku version/commit hash

v0.19.0

@jm-clius
Copy link
Contributor

Almost certainly closed by any fix for #1641

@fryorcraken
Copy link
Collaborator Author

Yes confirmed

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants