refactor: "feat: amending computeDigest func. + related test cases (#2132)"

[ABresting]

This reverts commit 1669f71.

Description

As discussed with Hanno earlier, this will revert the computeDigest PR introduced in Waku archive and associated test cases changes as well.
We are doing this to make sure that we keep original behavior intact and use waku_core https://github.com/waku-org/nwaku/blob/master/waku/waku_core/message/digest.nim#L29 for computing messageHash attribute of database.

Changes

• revert the commit

Issue

#2112

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2180

Built from aad9645

[jm-clius]

I'm a bit confused, as I didn't realise that this was already merged into master. These changes seemed to still be part of the recently opened PR that changed the DB schema, but perhaps it was simply a polluted diff?
It would be good to understand what the actual impact is in terms of client implementation backwards compatibility if the underlying cursor is changed.

[ABresting]

I'm a bit confused, as I didn't realise that this was already merged into master. These changes seemed to still be part of the recently opened PR that changed the DB schema, but perhaps it was simply a polluted diff? It would be good to understand what the actual impact is in terms of client implementation backwards compatibility if the underlying cursor is changed.

This was a separate PR since on for issue #2112 tasks are done serially to have a visible separation component-wise merging in, that PR modified the computeDigest functionality.

AFAIK, this change only improved the cursor functionality since with new digest/id computed as per the RFC value, in js-Waku it failed a test case value and it was due to the existing digest functionality not updated in the jsWaku client.

in jsWaku and goWaku client it passed all test cases. About backwards compatibility idk tbh. @jm-clius WDYT?