Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Deterministic message hashing algorithm #2215

Closed
2 tasks done
ABresting opened this issue Nov 14, 2023 · 0 comments · Fixed by #2233
Closed
2 tasks done

chore: update Deterministic message hashing algorithm #2215

ABresting opened this issue Nov 14, 2023 · 0 comments · Fixed by #2233
Assignees
@ABresting

Comments

@ABresting
Copy link
Contributor

ABresting commented Nov 14, 2023 •
edited
Loading

Background

To strengthen the deterministic hash algorithm present in the RFC, sender timestamp should be a part of the deterministic message hash computation. As discussed in the vac research/doc vacp2p/rfc#632.

Details

The sender timestamp is added to the deterministic hash computation function/

Acceptance criteria

  • unique message hashes are generated
  • existing test cases remain unaffected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABresting ABresting

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deterministic message hash algorithm updated waku-org/nwaku
1 participant
@ABresting