Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(REST): adding to /admin/v1/peers response lightpush and filter v2 peer info #2220

Closed
1 task done
gabrielmer opened this issue Nov 15, 2023 · 2 comments · Fixed by #2219
Closed
1 task done

chore(REST): adding to /admin/v1/peers response lightpush and filter v2 peer info #2220

gabrielmer opened this issue Nov 15, 2023 · 2 comments · Fixed by #2219
Assignees
@gabrielmer
Labels
enhancement New feature or request

Comments

@gabrielmer
Copy link
Contributor

Background

Currently /admin/v1/peers endpoint only returns peer information regarding Store, Relay and legacy Filter protocols.
We want to include info for Lightpush and Filter v2, for both convenience and consistency with go-waku.

Once we deprecate the legacy Filter protocol we should remove it from the response.

Acceptance criteria

A list of tasks that need to be done for the issue to be considered resolved.

  • Lightpush and Filter v2 peer info should be displayed on /admin/v1/peers response
@gabrielmer gabrielmer self-assigned this Nov 15, 2023
@gabrielmer gabrielmer mentioned this issue Nov 15, 2023
Merged
2 tasks
@gabrielmer gabrielmer moved this to In Progress in Waku Nov 15, 2023
@gabrielmer
Copy link
Contributor Author

Weekly Update

  • achieved: implemented, tested and raised PR
  • next: get PR reviewed, implement feedback and merge

@chair28980 chair28980 added the enhancement New feature or request label Nov 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Nov 22, 2023
@gabrielmer
Copy link
Contributor Author

Weekly Update

  • achieved: merged PR and closed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielmer gabrielmer

Labels
enhancement New feature or request
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(REST): returning lightpush support and updated filter protocol waku-org/nwaku
2 participants
@chair28980 @gabrielmer