Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add sharding information to peer storage #2237

Closed
2 tasks done
SionoiS opened this issue Nov 22, 2023 · 2 comments · Fixed by #2243
Closed
2 tasks done

chore: add sharding information to peer storage #2237

SionoiS opened this issue Nov 22, 2023 · 2 comments · Fixed by #2243
Assignees
@SionoiS
Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details

Comments

@SionoiS
Copy link
Contributor

SionoiS commented Nov 22, 2023 •
edited
Loading

Background

Before the introduction of sharding, much less information was need to connect to remote peers. The new shard aware peer manager must have solid information about peers to function. Sharding info. is now required.

Details

The intent is to refactor the peer storage so that all peer information, sharding included, is saved.

Acceptance criteria

  • a peer cluster id and shard is save in the peer storage
  • refactor peer storage for ergonomics and efficiency

N.B. peer store != peer storage
@SionoiS SionoiS added the E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details label Nov 22, 2023
@SionoiS SionoiS self-assigned this Nov 22, 2023
@SionoiS SionoiS mentioned this issue Nov 22, 2023
Merged
3 tasks
@SionoiS SionoiS changed the title chore: add sharding information to the peer store chore: add sharding information to peer storage Nov 23, 2023
@SionoiS SionoiS mentioned this issue Nov 23, 2023
Merged
3 tasks
@SionoiS
Copy link
Contributor Author

SionoiS commented Nov 24, 2023

Weekly Update

  • achieved: updated peer storage to include ENR
  • next: review feedback cycle

@github-project-automation github-project-automation bot moved this to Done in Waku Nov 27, 2023
@SionoiS
Copy link
Contributor Author

SionoiS commented Nov 27, 2023

Weekly Update

  • achieved: merged and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SionoiS SionoiS

Labels
E:1.4: Sharded peer management and discovery See https://github.com/waku-org/pm/issues/67 for details
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactoring peer storage waku-org/nwaku
1 participant
@SionoiS