fix: extended Postgres code to support retention policy + refactoring #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
ABresting
changed the title
|
You can find the image built from this PR at Built from a9391f4 |
ABresting
added
the
release-notes
SionoiS
approved these changes
Nov 24, 2023
Ivansete-status
approved these changes
Nov 24, 2023
Co-authored-by: Simon-Pierre Vivier <simvivier@status.im>
Since it is on the node level, then we use MiB i.e. denominator is 1024 not 1000 |
I think I saw a MB somewhere. |
SionoiS
approved these changes
Nov 24, 2023
SionoiS
requested changes
Nov 24, 2023
SionoiS
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug was caused due to Postgres not supporting the SQLite like functionality on the retention policy. Changes introduce Postgres to calculate the database size. Also, some refactoring for a cleaner code interface.
The calculation form GB/MB to bytes is done wrong on purpose since it touches the client-facing interface thus requires a wider conversation and will be corrected in a different PR under the #2247
Changes
Issue
closes #2242