Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: including content topics on FilterSubscribeRequest logs #2295

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

gabrielmer
Copy link
Contributor

Description

Currently, when receiving a Filter subscription request, the content topics subscribed to were not getting logged.
Modified the logging so content topics are included.

Changes

  • added content topics to FilterSubscribeRequest prints
logging-filterequest

Copy link

github-actions bot commented Dec 14, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2295

Built from a2c099f

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for it!

@gabrielmer gabrielmer merged commit 306c8a6 into master Dec 15, 2023
9 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-improving-filter-subscribe-logging branch December 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants