Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: running validators in /relay/v1/auto/messages/{topic} #2394

Merged

Conversation

gabrielmer
Copy link
Contributor

Description

Small PR adding for the /relay/v1/auto/messages/{topic} endpoint the same checks implemented in #2373 for /relay/v1/messages/{topic}

Changes

  • running subscribed validators in POST /relay/v1/auto/messages/{topic} endpoint
  • added test case

Issue

closes #2284

Copy link

github-actions bot commented Feb 2, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2394

Built from bcce324

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for me! Thank you!

@gabrielmer gabrielmer merged commit e4e147b into master Feb 5, 2024
9 of 10 checks passed
@gabrielmer gabrielmer deleted the chore-add-validations-in-rest-relay-auto-endpoint branch February 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: REST API - large messages does not seem to be rejected by relay auto api
3 participants