You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
let conn =await node.switch.dial(peer.peerId, peer.addrs, PingCodec)
let pingDelay =await node.libp2pPing.ping(conn)
However the connections are never closed
We rely on libp2p's default connection limits. For example proc withMplex*(b: SwitchBuilder, inTimeout = 5.minutes, outTimeout = 5.minutes, maxChannCount = 200): SwitchBuilder
If that's not set by libp2p (what has happened us with yamux), the number of connections grows indefinitely.
We should close unused connections ourselves.
Acceptance criteria
Unused connections are deliberately closed
The text was updated successfully, but these errors were encountered:
At some point we considered disabling/removing keepAlive, but we ended up just disabling it. The feature its still there and used by eg waku-simulator. While it's not the root cause of this issue, removing it should fix the problem. At this point, I'm not sure it makes sense to have it.
cc @vpavlin Guess your network monitor will get crazy with this?
Background
A node pings its peers every 2 minutes in
nwaku/waku/node/waku_node.nim
Lines 1072 to 1073 in 56ff30c
However the connections are never closed
We rely on libp2p's default connection limits. For example
proc withMplex*(b: SwitchBuilder, inTimeout = 5.minutes, outTimeout = 5.minutes, maxChannCount = 200): SwitchBuilder
If that's not set by libp2p (what has happened us with yamux), the number of connections grows indefinitely.
We should close unused connections ourselves.
Acceptance criteria
Unused connections are deliberately closed
The text was updated successfully, but these errors were encountered: