fix: return message id on waku_relay_publish

[richard-ramos]

Description

As defined in the bindings, waku_relay_publish returns a message id on success

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2485

Built from bb57b8c

[gabrielmer]

LGTM, thanks so much!

[SionoiS]

LGTM

[Ivansete-status]

Great! Thanks for it!

[Ivansete-status]

Hey @richard-ramos ! Sorry for confusion but right after approving the PR I thought that it may be more convenient to use the same mechanism that we have to generate the msd_id within GossipSub:

nwaku/waku/waku_relay/message_id.nim

Lines 31 to 33 in d832f92

	proc defaultMessageIdProvider*(message: messages.Message): Result[MessageID, ValidationResult] =
	let hash = sha256.digest(message.data)
	ok(@(hash.data))

[richard-ramos]

I thought that it may be more convenient to use the same mechanism that we have to generate the msd_id within GossipSub

Actually, it is the messageHash we need! so that makes me think that i have to rename the messageId field in https://rfc.vac.dev/spec/36/#jsonmessageevent-type to messageHash. WDYT? I can do that change in this PR

[Ivansete-status]

I thought that it may be more convenient to use the same mechanism that we have to generate the msd_id within GossipSub

Actually, it is the messageHash we need! so that makes me think that i have to rename the messageId field in https://rfc.vac.dev/spec/36/#jsonmessageevent-type to messageHash. WDYT? I can do that change in this PR

Ok cool! I think messageHash sounds better but no need to rush for that change

[richard-ramos]

Implemented the change in last commit :)