fix: node restart test issue #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
force-pushed
the
fix-node-restart-test-issue
branch
from
d18c302 to
9e47b93
Compare
|
You can find the image built from this PR at Built from 99d2cba |
- Is not necessary to start the node if the switch object has been started - Enable an existing "Relay can receive messages after reboot and reconnect" test - Explicit reconnect to peer in "Relay can receive messages after reboot and reconnect" test
…ch proc With that, we avoid double start of the protocol.
Ivansete-status
force-pushed
the
fix-node-restart-test-issue
branch
from
9e47b93 to
577084e
Compare
Ivansete-status
requested review from
AlejandroCabeza,
NagyZoltanPeter and
gabrielmer
gabrielmer
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
LGTM, thanks so much!
I wonder if this had the same root cause as #2592
ah maybe yes, thanks for the heads-up! I'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been detected an issue regarding node restart and reconnection. After reconnecting, the messages didn't get its destination.
Changes
test_protocol.nimso that it doesn't start things twice, f.e. the relayIssue
Special thanks to @AlejandroCabeza for such a great issue description 🥳
closes #2145