Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rest store: content_topic -> contentTopic in the response #2584

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix: rest store: content_topic -> contentTopic in the response #2584

merged 2 commits into from
Apr 12, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Standardize the contentTopic field returned by store rest

Issue

closes #2582

@Ivansete-status Ivansete-status self-assigned this Apr 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2584-rln-v2-true

Built from 5cf532c

gabrielmer
gabrielmer approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you!

NagyZoltanPeter
NagyZoltanPeter approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Ivansete-status Ivansete-status marked this pull request as ready for review April 12, 2024 15:47
@Ivansete-status Ivansete-status merged commit d257855 into master Apr 12, 2024
13 of 15 checks passed
@Ivansete-status Ivansete-status deleted the fix-content-topic-name-rest-store branch April 12, 2024 15:47
gabrielmer added a commit that referenced this pull request Apr 25, 2024
@gabrielmer
Revert "fix: rest store: content_topic -> contentTopic in the response (
dfca645 
#2584)"

This reverts commit d257855.
@fbarbu15 fbarbu15 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: contentTopic naming not consistent in the store response where is's content_topic
3 participants
@Ivansete-status @gabrielmer @NagyZoltanPeter