Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store v3 proto field numbers #2632

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: store v3 proto field numbers #2632

merged 1 commit into from
Apr 25, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Apr 25, 2024 •
edited
Loading

@SionoiS SionoiS self-assigned this Apr 25, 2024
@SionoiS SionoiS changed the title Fix: store v3 proto field numbers fix: store v3 proto field numbers Apr 25, 2024
@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2632-rln-v1

Built from 010bb43

@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2632-rln-v2

Built from 010bb43

NagyZoltanPeter
NagyZoltanPeter approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but hard to judge without seeing the proto definition.
I guess this will go with this: waku-org/waku-proto#22

@SionoiS
Copy link
Contributor Author

SionoiS commented Apr 25, 2024

Looks good, but hard to judge without seeing the proto definition. I guess this will go with this: waku-org/waku-proto#22

this is the best we have. https://github.com/vacp2p/rfc/tree/docs/new-store-v3-protocol/content/docs/rfcs/13#payloads WIP

@NagyZoltanPeter
Copy link
Contributor

Looks good, but hard to judge without seeing the proto definition. I guess this will go with this: waku-org/waku-proto#22

this is the best we have. https://github.com/vacp2p/rfc/tree/docs/new-store-v3-protocol/content/docs/rfcs/13#payloads WIP

Great thanks! I overlooked on it in the description. so far so good!

@SionoiS SionoiS merged commit 843fe21 into master Apr 25, 2024
11 of 22 checks passed
@SionoiS SionoiS deleted the fix--store-v3-proto branch April 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

Assignees

@SionoiS SionoiS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SionoiS @NagyZoltanPeter @richard-ramos