refactor: metrics server. Simplify app.nim module #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 5929a3d |
|
You can find the image built from this PR at Built from 5929a3d |
Ivansete-status
requested review from
NagyZoltanPeter,
SionoiS,
gabrielmer and
chaitanyaprem
NagyZoltanPeter
approved these changes
Apr 30, 2024
| return | ||
| err("Starting metrics server failed. Continuing in current state:" & $error) | ||
|
|
||
| if conf.metricsLogging: |
There was a problem hiding this comment.
Just out of curiosity, is there a mean having metrics server running without metrics logging?
There was a problem hiding this comment.
I guess you can scrape the metrics for monitoring purposes without it polluting the logs?
There was a problem hiding this comment.
Good question @NagyZoltanPeter !
Yes, that could happen indeed. The metrics server is just an http server that delivers current node state, and this can run separately. The log-metrics, is some kind of redundant metrics information that we print regularly in logs. Both are similar but can run separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify
app.nimand move the "metrics factory" procs to an already existingwaku_metricsmodule