fix: store v3 misc bugs #2718
Merged
fix: store v3 misc bugs #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 6b08807 |
|
You can find the image built from this PR at Built from 6b08807 |
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
SionoiS
changed the title
NagyZoltanPeter
approved these changes
May 23, 2024
|
Ran all the related tests locally. Will merge even if CI is broken. 🤞 |
This was referenced May 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bug fixes.
For #2717
I just remove the
assertand the code handle the error just fine.For #2715
I turn off the plus sign for url de/encoding and change to base 64 for json.
For #2716
I added a cursor check before the main query.
For #2719
I change the serde for REST api