chore: enhance libpq management #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 186d3a7 |
Ivansete-status
requested review from
NagyZoltanPeter,
SionoiS and
darshankabariya
NagyZoltanPeter
approved these changes
Sep 4, 2024
SionoiS
approved these changes
Sep 5, 2024
|
|
||
| return err("failed pqconsumeInput: unknown reason") | ||
| asyncengine.addReader2(asyncFd, onDataAvailable).isOkOr: |
There was a problem hiding this comment.
AFAIU chronos will trigger onDataAvailable directly on a socket read instead of doing db.check() which is slower right?
There was a problem hiding this comment.
AFAIU chronos will trigger
onDataAvailabledirectly on a socket read instead of doingdb.check()which is slower right?
Yes correct :) In fact, the functions pqGetResult and pqConsumeInput ( libpq-async ) doesn't behave well in high load conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have better libpq data retrieval. In this PR we are starting to register the underlying socket FD into the chronos selectors so that we have a more optimized time management.
Also adding a metric to allow measuring the time spent in database queries and the time spent returning the response to the store client.
This is inspired by @Menduist 's comment: https://github.com/waku-org/nwaku/pull/1631/files#r1153293945