chore: libwaku - extending the library with peer_manager and peer_exchange features #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
changed the title
|
You can find the image built from this PR at Built from 3c9680e |
Ivansete-status
requested review from
gabrielmer,
SionoiS,
darshankabariya and
NagyZoltanPeter
gabrielmer
approved these changes
Sep 9, 2024
Comment on lines
+329
to
+331
| WAKU_CALL( waku_get_peerids_from_peerstore(ctx, | ||
| event_handler, | ||
| userData) ); |
There was a problem hiding this comment.
Why do we need this call?
SionoiS
approved these changes
Sep 9, 2024
library/waku_thread/inter_thread_communication/requests/peer_manager_request.nim
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One more step towards exposing nwaku through libwaku. The exposed features are currently needed by status-go.
Notice that there will be more upcoming features soon.
Changes
Adding new features: