Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: filter service node creates a new stream for every single message #3192

Open
Ivansete-status opened this issue Dec 3, 2024 · 2 comments · May be fixed by #3198
Open

bug: filter service node creates a new stream for every single message #3192

Ivansete-status opened this issue Dec 3, 2024 · 2 comments · May be fixed by #3198
Assignees
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week

Comments

@Ivansete-status
Copy link
Collaborator

Problem

While running the following example: https://github.com/waku-org/lab.waku.org/tree/066be09ee11fba01b3c6f8ed0e5966de88225104/examples/experimental/railgun-repro
... against a nwaku node base on Railgun infra, @danisharora099 discovered that we easily reach the limit of max number of streams (see https://github.com/waku-org/js-waku/blob/88e33a90fd2a4de93d4ce0cb99dbd77ff454ef34/packages/core/src/lib/filter/index.ts#L47.)

Therefore, we are apparently creating a new stream for every message that is being sent to the subscribed filter clients.
We need to use the same stream for all messages.

Thanks so much @danisharora099 for such great tool! Super insightful 😍

Waku version

v0.33.1

@Ivansete-status Ivansete-status added the bug Something isn't working label Dec 3, 2024
@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Dec 3, 2024
@Ivansete-status Ivansete-status moved this to In Progress in Waku Dec 3, 2024
@Ivansete-status Ivansete-status self-assigned this Dec 3, 2024
@danisharora099
Copy link

IMO this is now resolved? Or is there more followup expected?

@Ivansete-status
Copy link
Collaborator Author

Hey there @danisharora099 !
I'm adapting the nwaku tests to the new implementation. Once the tests pass properly I'll set the PR #3198 as ready for review and once merged, I will close that one :D

@gabrielmer gabrielmer moved this from In Progress to Code Review / QA in Waku Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week
Projects
Status: Code Review / QA
Development

Successfully merging a pull request may close this issue.

2 participants