Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim-waku v0.8 & v0.9 release ubuntu asset does not work #883

Closed
D4nte opened this issue Mar 7, 2022 · 5 comments
Closed

nim-waku v0.8 & v0.9 release ubuntu asset does not work #883

D4nte opened this issue Mar 7, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@D4nte
Copy link
Contributor

D4nte commented Mar 7, 2022

The ubuntu nim-waku asset on release v0.8 https://github.com/status-im/nim-waku/releases does not work. More specifically the wakunode2 binary:

GitHub Action ubuntu (works with 0.7)

./build/wakunode2 --help
vendor/rln/target/debug/librln.so: cannot open shared object file: No such file or directory
could not load: vendor/rln/target/debug/librln.so
@staheri14
Copy link
Contributor

It is not expected, rln is off by default. How binaries are generated? cc: @jm-clius

@jm-clius
Copy link
Contributor

Binaries are not created with rln enabled. It uses this simple make command: https://github.com/status-im/nim-waku/blob/master/.github/workflows/release-assets.yml#L45

@D4nte
Copy link
Contributor Author

D4nte commented Apr 1, 2022

Please note this is not fixed with v0.9, using the ubuntu-latest asset attached to the release:

$  uname -a
Linux fv-az275-730 5.11.0-1028-azure #31~20.04.2-Ubuntu SMP Tue Jan 18 08:46:15 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
$  ./wakunode2 --help
/home/runner/work/_temp/b3e33e1c-07f8-4e15-84de-7c70ba22cfd4.sh: line 3:  1648 Illegal instruction     (core dumped) ./wakunode2 --help

@D4nte D4nte changed the title nim-waku v0.8 release ubuntu asset does not work nim-waku v0.8 & v0.9 release ubuntu asset does not work Apr 1, 2022
@D4nte D4nte added the bug Something isn't working label Apr 1, 2022
@jm-clius
Copy link
Contributor

jm-clius commented Apr 1, 2022

Yeah, I noticed as well, even thought the RLN issue was fixed. Looking into this.

@jm-clius
Copy link
Contributor

jm-clius commented Apr 5, 2022

Closing this issue, as I've now updated v0.8 and v0.9 releases with working Ubuntu assets (happy to reopen if you notice any further issues).
However, the automated GH workflow that creates the assets remains unreliable despite attempting several fixes. It often produces corrupt binaries. A more reliable mechanism, perhaps using Jenkins, is needed for future releases and already tracked in: #611

@jm-clius jm-clius closed this as completed Apr 5, 2022
@jm-clius jm-clius moved this to Done in Waku Product (old) Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants