Waku Relay messages detected exceeding max size of 1 MB

[jm-clius]

Background

As part of the investigations into waku-org/nwaku#1662 and #23, we've noticed that nwaku nodes are logging (and rejecting) messages on the relay (gossipsub) network of size upwards of 2 MB. The maximum size of gossip messages are 1 MB.

Problem

This issue tracks the investigation into the origin of these oversized messages.
The first step would be to verify that each of the three main Waku clients are configured to reject messages of larger than 1 MB:

• nwaku (confirmed here and the fact that it's logging that it's rejecting large messages)
• js-waku feat: reject 1MB and above messages js-waku#1342
• go-waku cc @richard-ramos

A second step would be to verify that this setting does indeed work as expected practically. :)

[alrevuelta]

Related vacp2p/nim-libp2p#887. The log we are seeing in nwaku is not the gossipsub message size itself but the messages encoded in the IWANT.

So this doesn't necessarily mean that someone is sending messages >1MB.

[richard-ramos]

In go-libp2p-pubsub, the default max message size is set to 1 MiB https://github.com/libp2p/go-libp2p-pubsub/blob/1e161006c43f20435c2735bf24560f4d2d7eb429/pubsub.go#L249 . I did a quick test with basic2 example and can confirm that messages greater than this will be dropped.

[weboko]

In js-waku/GossipSub I do not see any restrictions on the size of the message.
I'll to follow-up with a restriction to the size
cc: @fryorcraken

[fryorcraken]

@weboko please create a tracking issue

[fryorcraken]

This seems done