-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow to update test results in VS Code when using typescript and esbuild #2946
Comments
Sorry for transfer confusion... description said Quokka - had thought this was in the wrong repo. Is actually Wallaby |
🤦 my bad sorry! |
We're not exactly sure of the cause yet, but the issue seems to be related to We patched "use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var esbuild_1 = require("./esbuild");
require("./register");
function process(src, filename) {
console.log('*****************************');
console.log('esbuild-input:src', src);
console.log('*****************************');
console.log('esbuild-input:filename', filename);
const result = (0, esbuild_1.transpile)(src, filename, { type: "transform" });
console.log('*****************************');
console.log('esbuild-output', result);
console.log('*****************************');
return result;
}
exports.default = { process: process }; And we can see that the correct inputs are being provided to esbuild, but it's returning the wrong output:
We'll keep investigating to see if we can work out why esbuild is returning the wrong value. |
We found that We have had some other customers successfully use esbuild-jest instead of what you are using, esbuild-runner. I'll raise an issue in |
We've created a pull request that should fix the issue. folke/esbuild-runner#51 Since the issue isn't related to Wallaby and there are potential workarounds (e.g. use a different esbuild-jest transformer) I believe we can close this issue. If you're still having problems, let us know and we can reopen it. |
Thank you @smcenlly , you have been incredibly responsive and helpful. Switching to (Of course, it's possible that your pull request in |
Issue description or question
Wallaby is very slow to update test results, largely defeating the purpose of the tool. I often have to make other random changes (like empty newlines) and/or save the file in order for it to update.
The following video illustrates the problem. In particular, notice that the test time keeps updating (so Wallaby is re-running the test) but the results aren't changing (so it appears Wallaby is looking at the wrong code). Sometimes saving the file forces Wallaby to update, but by no means always.
Quokka.slow.to.update.mov
A reproduction repository is available here: https://github.com/abirtley/quokka-slow-typescript-reproduction
I have based this on a https://github.com/serverless-stack/serverless-stack example (specifically, the typescript monorepo example) but pulled out everything but the typescript configuration, jest configuration, and simple code files.
Note that the Wallaby demo worked fine on my computer, and did not have this problem.
I expect it might have something to do with the typescript configuration in this particular project, but I'm not sure what to change in order to make Wallaby happy 😄
Wallaby diagnostics report
The text was updated successfully, but these errors were encountered: