-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass CloudFormation tags/parameters from file #145
Comments
any feedback on this one? I would really like to use it in the CI. I could work on the implementation, but don't really know how to add it :) |
To be honest I did not get it the first time I read it and I wanted to come back to it. I'm giving it another read. If you do not mind you could explain the workflow with your CI, with the ideal |
If I understand correctly, in that template stack configuration file we have the Parameters section and the StackPolicy which represent the same as the So we could introduce a new parameter to do It would means we would have to slurp files in both Or am I completely wrong ? |
Ok, I see there is the Through |
@simcap yes, you understand it correctly. This way I can have 1 template file and couple stack files (for each env), because currently, I have to place dozens of parameters in the CLI command and it is very hard to read and support. |
Ok. We shall implement that (both yaml and json support). Not sure when though. Maybe in the 0.1.5, seems it is quite useful indeed for pipelines and CI |
Any update on this one? Just one more thing came to my mind, is the ability to combine Use case: So it would be nice to be able to specify To avoid using |
By the way, if you give me a hint how to add functionality to the generated code I could work on it if I have time next week. |
Thanks for the additional feedback (and the detailed use case). |
@fxaguessy I guess after the Do you have some plan to work on it, or better for me to take it once I have a free hour? |
@trane9991 yes, it will be now easier to implement that thanks to our latest re-modelling of AWS integration. At the moment we are working on the 0.1.7 (due this week) and maybe the 0.1.8 next week for AWS re:Invent since the team will be there to present the tool. So we will be a bit busy. I might have some time next week to have a look. Since we have to support multi format, this is not an quick feature, and it should be done properly. We update in this issue accordingly. |
@simcap good luck on the re:Invent 🥇 , I wish I could go there too :D |
@simcap @fxaguessy usage example as promised: So, mine use case of awless is mostly CI pipeline for deployment of CloudFormation templates. So basically each of my projects has the template-file -
in the stack-file I keep the static CloudFormation template parameters and tags, docker image version tag I prefer to supply via By the way, I think that
I think next step here is to add support of rollback-triggers (#157) to make deployment rollback smarter than just timeout. |
Thanks a lot for the info! |
In order to use awless as part of CI job for deployment CloudFormation, would be very nice to be able to apply parameters from the file.
AWS has this kind of file for deployment with CodePipeline: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/continuous-delivery-codepipeline-cfn-artifacts.html#w2ab2c13c15c15. Would be very nice to be able to support the same file format.
I took a look at the
update stack
code, and everything is autogenerated there and I'm not sure how to add functionality there.The text was updated successfully, but these errors were encountered: