Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walls accepts invalid dates where day-of-month is invalid (example June 31 is accepted but June only has 30 days) #35

Open
vaxheadroom opened this issue Jan 3, 2025 · 0 comments

Comments

@vaxheadroom
Copy link

Day-of-month validation for #DATE directive is overly simplistic. Walls only checks to make sure day-of-month is <=31. "31" is accepted for months with only 30 days. 29,30 and 31 are accepted for February which has only 28 or 29 days, depending on leap-year.

This issue does not appear to be causing problem within Walls, including date-based magnetic declination calculations.

However, breakage occurs downstream during processing of Walls-exported "shapefiles" if one attempts to cast the survey date into a field type of "date" (the Walls-exported shapefile uses field type of "text", which prevents date-based math). Similar issues may be encountered by other apps which attempt to processes the native Walls .srv files.

Was not able to identify the offending source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant